This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• swy-sdl2-win32-getwindowborderssize.diff (swy-sdl2-win32-getwindowborderssize.diff, text/plain, 2017-12-31 19:46:20 +0000, 3509 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: Windows (All), All

Comments on the original bug report:

On 2017-12-31 19:46:20 +0000, Ismael Ferreras Morezuelas (Swyter) wrote:

Created attachment 3122
swy-sdl2-win32-getwindowborderssize.diff

As a new year gift I have implemented the Windows version of SDL_GetWindowBordersSize(). I needed it for auto-selecting a cozy window size for the game I'm currently working on and noticed that it only worked under X11, so I thought it could be a good excuse to contribute back more stuff. The Mercurial patch is attached as a .diff file. Let me know what you think.

Happy 2018 to all the SDL2 devs and users!

--

PS: Keep in mind that Windows 10 includes the 8px invisible grip borders as part of the frame. There's a way of detecting if Aero/DWM is being used and ask only for the visible rect, but I believe that GetWindowRect() is doing that for a reason and working as intended, so I haven't changed it. (See [2])

References:
[1]: http://www.firststeps.ru/mfc/winapi/r.php?72
[2]: https://stackoverflow.com/a/34143777/674685
[3]: https://stackoverflow.com/a/431548/674685
[4]: https://wiki.libsdl.org/SDL_GetWindowBordersSize

On 2018-01-03 18:52:16 +0000, Sam Lantinga wrote:

Added, thanks!
https://hg.libsdl.org/SDL/rev/16dbfcc5e455

Happy New Year! :)