This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• use css size for touch normalisation (0001-use-css-size-for-touch-normalisation.txt, text/plain, 2016-04-12 14:55:01 +0000, 1485 bytes)
• simplify fullscreen handling using new fullscreen_strategy api (0002-simplify-fullscreen-handling-using-new-fullscreen_stra.txt, text/plain, 2016-04-12 14:55:53 +0000, 9378 bytes)
• use SDL_SetMouseFocus (0003-use-SDL_SetMouseFocus.txt, text/plain, 2016-04-12 14:56:52 +0000, 864 bytes)
• listen for mouse up on document (fixes mouseup outside canvas) (0004-listen-for-mouse-up-on-document-fixes-mouseup-outside-.txt, text/plain, 2016-04-12 14:59:05 +0000, 1563 bytes)
• send mouse move on enter/leave (0005-send-mouse-move-on-enter-leave.txt, text/plain, 2016-04-12 15:00:24 +0000, 1394 bytes)
• Include timers when using cmake (0006-Include-timers-when-using-cmake-29.txt, text/plain, 2016-04-12 15:02:00 +0000, 845 bytes)
• optimize a getValue (0007-optimize-a-getValue.txt, text/plain, 2016-04-12 15:03:09 +0000, 793 bytes)
• optimize Emscripten_UpdateWindowFramebuffer (0008-optimize-Emscripten_UpdateWindowFramebuffer.txt, text/plain, 2016-04-12 15:04:18 +0000, 4612 bytes)
• Fix of mouse events in browser without pointer locks (0009-Fix-of-mouse-events-in-browser-without-pointer-locks.txt, text/plain, 2016-04-12 15:05:31 +0000, 2689 bytes)
• Accumulate subpixel mouse motion so motion is not lost. (0010-Accumulate-subpixel-mouse-motion-so-motion-is-not-lost.txt, text/plain, 2016-04-12 15:07:17 +0000, 2522 bytes)
• Mouse events use CSS coordinates, so don't scale by pixel_ratio (0011-Mouse-events-use-CSS-coordinates-so-don-t-scale-by-pix.txt, text/plain, 2016-04-12 15:07:50 +0000, 1705 bytes)
• Listen for blur and focus events on window instead of canvas (0012-Listen-for-blur-and-focus-events-on-window-instead-of-.txt, text/plain, 2016-04-12 15:08:51 +0000, 1731 bytes)
• Unpress all keys on blur to avoid stuck keys (0013-Unpress-all-keys-on-blur-to-avoid-stuck-keys.txt, text/plain, 2016-04-12 15:14:51 +0000, 995 bytes)
• Fix CMake CMAKE_REQUIRED_FLAGS handling to preserve existing CMake flags required by Emscripten toolchain. (0014-Fix-CMake-CMAKE_REQUIRED_FLAGS-handling-to-preserve-ex.txt, text/plain, 2016-04-12 15:16:43 +0000, 3214 bytes)
• Remove unused variable warning from Emscripten build in Emscripten_HandleFullscreenChange(). (0015-Remove-unused-variable-warning-from-Emscripten-build-i.txt, text/plain, 2016-04-12 15:17:18 +0000, 851 bytes)
• [Support SDL_SetWindowTitle() via Module'setWindowTitle' (0016-Support-SDL_SetWindowTitle-via-Module-setWindowTitle.txt, text/plain, 2016-04-12 15:18:48 +0000, 2008 bytes)](https://bugzilla.libsdl.org/attachment.cgi?id=2425)
• Fix full screen mode in Firefox, which was broken by 9d4beb2 (0017-Fix-full-screen-mode-in-Firefox-which-was-broken-by-9d.txt, text/plain, 2016-04-12 15:23:32 +0000, 990 bytes)
• use screen resolution instead of canvas size (0018-use-screen-resolution-instead-of-canvas-size.txt, text/plain, 2016-04-12 15:25:15 +0000, 955 bytes)
• only unset fullscreen flags if fullscreen failed (0019-only-unset-fullscreen-flags-if-fullscreen-failed.txt, text/plain, 2016-04-12 15:26:19 +0000, 1850 bytes)
• add some detail to fullscreen workaround comment (0020-add-some-detail-to-fullscreen-workaround-comment-versi.txt, text/plain, 2016-04-12 15:27:36 +0000, 949 bytes)
• use Module.createContext for 2D rendering in emscripten (0021-use-Module.createContext-for-2D-rendering-in-emscripte.txt, text/plain, 2016-04-12 15:28:21 +0000, 993 bytes)
• Add mapping for media keys (0022-Add-mapping-for-media-keys.txt, text/plain, 2016-04-12 15:29:04 +0000, 1610 bytes)
• Only prevent the default browser event handling when the specific event types aren't disabled by the user (0023-Only-prevent-the-default-browser-event-handling-when-t.txt, text/plain, 2016-04-12 15:29:43 +0000, 5115 bytes)

Reported in version: HG 2.0
Reported for operating system, platform: Other, Other

Comments on the original bug report:

On 2016-01-09 14:57:23 +0000, Charlie Birks wrote:

Not sure of the best way to submit these, but here's a link to the relevant commits:

spurious/SDL-mirror@master...Daft-Freak:squash

On 2016-01-13 14:06:02 +0000, Martin Gerhardy wrote:

+1 for these changes

On 2016-04-12 14:55:01 +0000, Charlie Birks wrote:

Created attachment 2410
use css size for touch normalisation

Prep for next patch

On 2016-04-12 14:55:53 +0000, Charlie Birks wrote:

Created attachment 2411
simplify fullscreen handling using new fullscreen_strategy api

On 2016-04-12 14:56:52 +0000, Charlie Birks wrote:

Created attachment 2412
use SDL_SetMouseFocus

On 2016-04-12 14:59:05 +0000, Charlie Birks wrote:

Created attachment 2413
listen for mouse up on document (fixes mouseup outside canvas)

On 2016-04-12 15:00:24 +0000, Charlie Birks wrote:

Created attachment 2414
send mouse move on enter/leave

On 2016-04-12 15:02:00 +0000, Charlie Birks wrote:

Created attachment 2415
Include timers when using cmake

On 2016-04-12 15:03:09 +0000, Charlie Birks wrote:

Created attachment 2416
optimize a getValue

On 2016-04-12 15:04:18 +0000, Charlie Birks wrote:

Created attachment 2417
optimize Emscripten_UpdateWindowFramebuffer

Significant optimisation to software rendering.

On 2016-04-12 15:05:31 +0000, Charlie Birks wrote:

Created attachment 2418
Fix of mouse events in browser without pointer locks

On 2016-04-12 15:07:17 +0000, Charlie Birks wrote:

Created attachment 2419
Accumulate subpixel mouse motion so motion is not lost.

On 2016-04-12 15:07:50 +0000, Charlie Birks wrote:

Created attachment 2420
Mouse events use CSS coordinates, so don't scale by pixel_ratio

On 2016-04-12 15:08:51 +0000, Charlie Birks wrote:

Created attachment 2421
Listen for blur and focus events on window instead of canvas

On 2016-04-12 15:14:51 +0000, Charlie Birks wrote:

Created attachment 2422
Unpress all keys on blur to avoid stuck keys

On 2016-04-12 15:16:43 +0000, Charlie Birks wrote:

Created attachment 2423
Fix CMake CMAKE_REQUIRED_FLAGS handling to preserve existing CMake flags required by Emscripten toolchain.

On 2016-04-12 15:17:18 +0000, Charlie Birks wrote:

Created attachment 2424
Remove unused variable warning from Emscripten build in Emscripten_HandleFullscreenChange().

On 2016-04-12 15:18:48 +0000, Charlie Birks wrote:

Created attachment 2425
Support SDL_SetWindowTitle() via Module'setWindowTitle'

On 2016-04-12 15:23:32 +0000, Charlie Birks wrote:

Created attachment 2426
Fix full screen mode in Firefox, which was broken by 9d4beb2

This one is a hack but we can't use fullscreen mode otherwise... (see emscripten-ports/SDL2#13 and emscripten-core/emscripten#3265)

On 2016-04-12 15:25:15 +0000, Charlie Birks wrote:

Created attachment 2427
use screen resolution instead of canvas size

Makes reported display mode actually match the screen.

On 2016-04-12 15:26:19 +0000, Charlie Birks wrote:

Created attachment 2428
only unset fullscreen flags if fullscreen failed

On 2016-04-12 15:27:36 +0000, Charlie Birks wrote:

Created attachment 2429
add some detail to fullscreen workaround comment

Comment on fullscreen hack

On 2016-04-12 15:28:21 +0000, Charlie Birks wrote:

Created attachment 2430
use Module.createContext for 2D rendering in emscripten

On 2016-04-12 15:29:04 +0000, Charlie Birks wrote:

Created attachment 2431
Add mapping for media keys

On 2016-04-12 15:29:43 +0000, Charlie Birks wrote:

Created attachment 2432
Only prevent the default browser event handling when the specific event types aren't disabled by the user

On 2016-04-12 15:32:03 +0000, Charlie Birks wrote:

Reminded about this today, so generated patches.

On 2016-09-01 14:11:51 +0000, Charlie Birks wrote:

Apart from "simplify fullscreen handling using new fullscreen_strategy api" and "Only prevent the default browser event handling when the specific event types aren't disabled by the user" these should still apply. Rebased versions of these are here:

Daft-Freak/SDL-emscripten@1cb4f14
Daft-Freak/SDL-emscripten@365e916

Is there anything I need to do to get these looked at?

On 2016-09-13 07:11:07 +0000, Sam Lantinga wrote:

Patches applied, thanks!