We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 954 - sdl-mixer flac test is not cross-compile friendly
Summary: sdl-mixer flac test is not cross-compile friendly
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: Other Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 03:28 UTC by Mike Frysinger
Modified: 2011-02-17 13:23 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Frysinger 2010-02-17 03:28:55 UTC 
the current flac test uses AC_TRY_RUN for no real reason.  the same exact result can be found via a simple compile test.

--- configure.in
+++ configure.in
@@ -417,16 +417,14 @@ if test x$enable_music_flac = xyes; then
         LIBS_SAVED="$LIBS"
         LIBS="-lFLAC"
         AC_MSG_CHECKING([for libflac so-name version >= $libflac_ver])
-        AC_TRY_RUN([
+        AC_TRY_COMPILE([
 #include "FLAC/export.h"
 #include "stdio.h"
-int main( int argc, char *argv[] ) {
+],[
 #if defined(FLAC_API_VERSION_CURRENT) && (FLAC_API_VERSION_CURRENT >= $libflac_ver)
-    return 0;
 #else
-    return 1;
+#error "old-flac"
 #endif
-}
 ], have_flac_ver=yes, have_flac_ver=no)
         LIBS="$LIBS_SAVED"
         AC_MSG_RESULT($have_flac_ver)
Comment 1 Sam Lantinga 2011-02-17 13:23:06 UTC 
This change is in, thanks!
http://hg.libsdl.org/SDL_mixer/rev/209152025a0e