We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 705 - Some *printf() format string fixes for TESTS.
Summary: Some *printf() format string fixes for TESTS.
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: x86 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-21 11:15 UTC by Sami Näätänen
Modified: 2009-09-26 02:58 UTC (History)
0 users

See Also:

Attachments
Patches two tests that had broken format strings in their *printf()'s. (2.00 KB, patch)
2009-02-21 11:15 UTC, Sami Näätänen 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Näätänen 2009-02-21 11:15:39 UTC 
Created attachment 299 [details]
Patches two tests that had broken format strings in their *printf()'s.

This fixes errors in format strings for testbitmap and testplatform.
NOTE! tested on 64bit system, so x86 tests are at least needed.

As I can't test if this is due to my glibc, gcc or other features of my system like the 64bitnes, I ask others with different kind of systems to also test the patch.

How to test:
apply the patch.
make and install.
make all the tests.
NO compiler warnings should be outputed from that!
run the testplatform test to make sure it works OK.


My test was on:

distro: Gentoo
glibc:  sys-libs/glibc-2.8_p20080602-r1
gcc:    sys-devel/gcc-4.3.3
Comment 1 Sam Lantinga 2009-09-26 02:58:16 UTC 
The last patch with the 64-bit number I had to revert because llX is required on 32-bit systems, but otherwise the patch looked great.

Thanks!