We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 572 - [PATCH] Please update PulseAudio driver
Summary: [PATCH] Please update PulseAudio driver
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: audio (show other bugs)
Version: 1.2.13
Hardware: x86 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-1.2.14
: 557 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-31 12:38 UTC by Lennart Poettering
Modified: 2009-09-21 05:11 UTC (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lennart Poettering 2008-03-31 12:38:00 UTC 
Please merge this patch for the PA driver in SDL.

http://0pointer.de/public/sdl-pulse-rework.patch

This patch:
- fixes buffering (i.e. reduces number of "fragments" to 2, doesn't defer
filling up of the buffer until the entire buffer ran completely empty.)
- drops $PASERVER and $PADEVICE env var support, since this is a duplication of
$PULSE_SERVER and $PULSE_SINK which the PA libs honor anyway.

This fixes the sound issues in all games I tested.
Comment 1 Ryan C. Gordon 2008-04-08 10:56:36 UTC 
This patch removes the setting of paattr.fragsize ... should we not have set that?

(If nothing else, we're not memset()'ing this struct, so it's going to be uninitialized data if we don't set it explicitly...)

--ryan.
Comment 2 Lennart Poettering 2008-05-05 16:02:42 UTC 
The fragsize is only relevant for recording. It's irrelevant for playback. It's safe to leave it uninitialized.
Comment 3 Jeremy Visser 2008-07-18 23:52:56 UTC 
*** Bug 557 has been marked as a duplicate of this bug. ***
Comment 4 Sven Arvidsson 2009-01-16 07:27:22 UTC 
At least a couple of games still have problems with cracks in the audio, Frozen-Bubble and X-moto. 

In both cases it's enough to just listen to the music playing in the menu. There are no such problems if SDL_AUDIODRIVER is set to esd or alsa.

In the downstream Mandriva bug, it's suggested to use mixlen*3 or *4, at the cost of higher latency.
Comment 5 Ryan C. Gordon 2009-09-13 16:33:37 UTC 
Tagging this bug with "target-1.2.14" so we can try to resolve it for SDL 1.2.14.

Please note that we may choose to resolve it as WONTFIX. This tag is largely so we have a comprehensive wishlist of bugs to examine for 1.2.14 (and so we can close bugs that we'll never fix, rather than have them live forever in Bugzilla).

--ryan.
Comment 6 Sam Lantinga 2009-09-21 01:04:55 UTC 
Thanks, this has been added to subversion for SDL 1.2.  Do you have a similar patch for SDL 1.3?  (http://www.libsdl.org/trunk/SDL)
Comment 7 Ozkan Sezer 2009-09-21 02:10:35 UTC 
This is, kind of, a duplicate of bug #698 which has an updated patch.  An old outdated version just went into SDL-1.2.
Comment 8 Sam Lantinga 2009-09-21 05:11:06 UTC 
Yeah, I noticed that.  The new good stuff is in subversion now.  Thanks!