We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 567 - FLAC support, libflac version requirement
Summary: FLAC support, libflac version requirement
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86 Linux
: P2 normal
Assignee: Austen Dicken
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-12 10:00 UTC by Ozkan Sezer
Modified: 2009-09-26 02:16 UTC (History)
0 users

See Also:

Attachments
Patch to add version check to configure (3.33 KB, patch)
2008-04-16 05:39 UTC, Austen Dicken 		Details | Diff
Patch to add FLAC version checking in configure (3.33 KB, patch)
2008-04-16 13:51 UTC, Austen Dicken 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2008-03-12 10:00:55 UTC 
FLAC support, as implemented in SDL_mixer requires flac version >= 1.1.3 :
I have 1.1.2 installed and it surely fails compiling.  Can you add a check
for

defined(FLAC_API_VERSION_CURRENT) && (FLAC_API_VERSION_CURRENT >= 8)

in the configure scripts (or document this requirement) please?
Sorry that I can't provide a patch, I'm not good with autotools stuff.

Regards,
Ozkan Sezer
Comment 1 Austen Dicken 2008-04-15 13:22:42 UTC 
I am currently working on a patch to get this tested during the configure script.  I'll have it posted in a few days.
Comment 2 Austen Dicken 2008-04-16 05:39:04 UTC 
Created attachment 252 [details]
Patch to add version check to configure

Added a patch to check for the proper version.  Not sure if it is done the best way possible but it does work.
Comment 3 Ozkan Sezer 2008-04-16 06:32:58 UTC 
(In reply to comment #2)
> Created an attachment (id=252) [details]
> Patch to add version check to configure
> 
> Added a patch to check for the proper version.  Not sure if it is done the best
> way possible but it does work.
> 

Seems to work for me on linux: 
configure: error: *** FLAC library so-name version >= 8 not found!

Although, it would probably be better to have a behavior like in
the case of --enable-music-mp3, ie. disable the option and spit out
a warning, instead, but that's a personal preference.
Comment 4 Austen Dicken 2008-04-16 13:51:02 UTC 
Created attachment 253 [details]
Patch to add FLAC version checking in configure

I modified the patch so that now it should only print a warning if the proper version of FLAC is not found, and then disable it.

Thanks for the suggestion!
Comment 5 Sam Lantinga 2009-09-26 02:16:38 UTC 
This is in for the next release.  Thanks!