We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 565 - FLAC patch changed the order of Mix_MusicType
Summary: FLAC patch changed the order of Mix_MusicType
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-07 09:42 UTC by Alam Arias
Modified: 2008-03-08 22:35 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alam Arias 2008-03-07 09:42:17 UTC 
in r3557 of SDL_Mixer, MUS_FLAC was added in the middle of Mix_MusicType list, so any program compiled with SDL_Mixer 1.2.8 and uses Mix_GetMusicType() and (MUS_MP3 or MUS_MP3_MAD) will be messed up when linked against this new SDL_Mixer code, let just move MUS_FLAC to the end of the list to fix this

diff --git a/SDL_mixer.h b/SDL_mixer.h
index 58e0713..4d6907a 100644
--- a/SDL_mixer.h
+++ b/SDL_mixer.h
@@ -103,9 +103,9 @@ typedef enum {
        MUS_MOD,
        MUS_MID,
        MUS_OGG,
-       MUS_FLAC,
        MUS_MP3,
-       MUS_MP3_MAD
+       MUS_MP3_MAD,
+       MUS_FLAC,
 } Mix_MusicType;

 /* The internal format for a music chunk interpreted via mikmod */
Comment 1 Ryan C. Gordon 2008-03-08 22:35:49 UTC 
Fixed in svn revision #3571.

Thanks!

--ryan.