We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5474 - [PATCH] SDL_dinputjoystick.c: fixes to dfDIJoystick2[] array from Wine git
Summary: [PATCH] SDL_dinputjoystick.c: fixes to dfDIJoystick2[] array from Wine git
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: All Windows (All)
: P2 normal
Assignee: Ozkan Sezer
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-17 11:15 UTC by Ozkan Sezer
Modified: 2021-01-22 17:20 UTC (History)
0 users

See Also:

Attachments
dfDIJoystick2 patch (8.42 KB, patch)
2021-01-17 11:15 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2021-01-17 11:15:19 UTC 
Created attachment 4675 [details]
dfDIJoystick2 patch

Attached patch applies two fixes from Wine git (Jan. 2020) to the
dfDIJoystick2[] array in SDL_dinputjoystick.c:

Fix V/A/FSlider dwOfs values in c_dfDIJoystick2
https://source.winehq.org/git/wine.git/commitdiff/af2f4194263702a946c65d255580176ee50b5914

Add missing ASPECT flags for c_dfDIJoystick2
https://source.winehq.org/git/wine.git/commitdiff/e2e100272ffede3c720da7bbd11b53ac0bcee8eb

OK to apply?
Comment 1 Ozkan Sezer 2021-01-22 17:12:10 UTC 
PING?
Comment 2 Sam Lantinga 2021-01-22 17:14:55 UTC 
Yep, go for it.
Comment 3 Ozkan Sezer 2021-01-22 17:20:15 UTC 
Patch applied as https://hg.libsdl.org/SDL/rev/057f79bfe7ff