We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5472 - windows/SDL_mmjoystick.c not functional
Summary: windows/SDL_mmjoystick.c not functional
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: All Windows (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-17 02:56 UTC by Ozkan Sezer
Modified: 2021-01-23 14:31 UTC (History)
0 users

See Also:

Attachments
patch that ports SDL_mmjoystick.c to struct _SDL_JoystickDriver (8.33 KB, patch)
2021-01-22 18:03 UTC, Ozkan Sezer 		Details | Diff
winmm and psp joystick patch (15.22 KB, patch)
2021-01-22 20:39 UTC, Ozkan Sezer 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2021-01-17 02:56:03 UTC 
Since commit https://hg.libsdl.org/SDL/rev/399cc39583cc, windows
SDL_mmjoystick.c isn't functional:  its SDL_SYS_JoystickXX procs
aren't called. We can adapt it to struct _SDL_JoystickDriver (if
its missed update wasn't intentional), or we can remove it if it
is way too outdated / unmaintainable.

psp/SDL_sysjoystick.c is in the same situation, although I don't
know whether it is (has ever been) functional..
Comment 1 Ozkan Sezer 2021-01-22 18:03:12 UTC 
Created attachment 4687 [details]
patch that ports SDL_mmjoystick.c to struct _SDL_JoystickDriver

Compile-tested only.
Comment 2 Ozkan Sezer 2021-01-22 20:39:29 UTC 
Created attachment 4690 [details]
winmm and psp joystick patch


Updated patch that ports winmm and psp joystick sources
to struct _SDL_JoystickDriver.  Build-tested only.
Comment 3 Ozkan Sezer 2021-01-23 14:31:11 UTC 
Applied the patch as https://hg.libsdl.org/SDL/rev/9378185b458d