We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5447 - msvc warning from SDL_windows_gaming_input.c
Summary: msvc warning from SDL_windows_gaming_input.c
Status: RESOLVED WONTFIX
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: All Windows 10
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-05 13:24 UTC by Ozkan Sezer
Modified: 2021-01-08 18:05 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2021-01-05 13:24:22 UTC 
Got the following from SDL_windows_gaming_input.c when built using
Visual Studio 2017 (15.9.30):

src\joystick\windows\sdl_windows_gaming_input.c(338): warning C4028: formal parameter 3 different from declaration
src\joystick\windows\sdl_windows_gaming_input.c(348): warning C4028: formal parameter 3 different from declaration
Comment 1 Sam Lantinga 2021-01-05 20:49:57 UTC 
I'm not seeing that with Visual Studio 2017. What Windows SDK are you targeting?
Comment 2 Ozkan Sezer 2021-01-05 21:16:55 UTC 
(In reply to Sam Lantinga from comment #1)
> I'm not seeing that with Visual Studio 2017. What Windows SDK are you
> targeting?

As prompted by VS2017 ide, and me OK'ing it:

Windows SDK Version: 10.0.17763.0
Platform Toolset: Upgrade to v141
Comment 3 Sam Lantinga 2021-01-05 22:02:48 UTC 
This is actually a bug in the 10.0.17763.0 SDK, which is fixed in newer versions.
Comment 4 Ozkan Sezer 2021-01-08 14:55:45 UTC 
(In reply to Sam Lantinga from comment #3)
> This is actually a bug in the 10.0.17763.0 SDK, which is fixed in newer
> versions.

Whatever that bug is, does it result in miscompilations or is it
just a warning?

VS installer isn't presenting me any newer SDM versions either.
Comment 5 Sam Lantinga 2021-01-08 18:05:36 UTC 
It's just a warning, the code works fine.