Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sudden stop in game while forward key is still being pressed #831

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

Sudden stop in game while forward key is still being pressed #831

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 1.2.15
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2020-12-30 18:20:37 +0000, wrote:

Created attachment 4618
Backport of [2] and [3] to libsdl1.2 which fixed the issue described in this bug report

Since some time I stated to observe an annoying bug with the forward movement suddenly stopping while I was still pressing the corresponding key for the forward movement. Releasing and pressing the key again continued the movement. I observed this in the game "Unreal Tournament 2004", but other software is probably also affected. The stop basically happens after a few minutues of pressing the key, through the time needed to reproduce the issue is not constant.
While investigating the issue I found it started with a commit [1] in the Xorg xserver. Digging deeper into the code I found two commits [2] [3] in libsdl2 which looked like they would also fix the issue in libsdl1.2. I backported these two commits to the libsdl1.2 in Debian and can confirm that the bug got fixed by this. I am attaching the patch for my backporting to this bug report.

As I've seen there is still development in the libsdl1.2 branch, I think this fix also should be included there.

[1] https://cgit.freedesktop.org/xorg/xserver/commit/?id=c67f2eac56518163981af59f5accb7c79bc00f6a
[2] https://hg.libsdl.org/SDL/rev/a1c4c17410e8
[3] https://hg.libsdl.org/SDL/rev/764129077d18

On 2020-12-30 19:20:03 +0000, Ozkan Sezer wrote:

Ryan, Sam: This looks good to me. OK to apply to SDL-1.2 branch?

On 2020-12-30 19:40:05 +0000, Sam Lantinga wrote:

Yep

On 2020-12-30 20:00:58 +0000, Ozkan Sezer wrote:

OK, patch applied as https://hg.libsdl.org/SDL/rev/336bcaa9432c
Thanks. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant