We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5401 - SDL_ShowSimpleMessageBox recently causing access violation
Summary: SDL_ShowSimpleMessageBox recently causing access violation
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: x86 Windows 10
: P2 blocker
Assignee: Ozkan Sezer
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.14
Depends on:
Blocks:
 
Reported: 2020-12-17 16:51 UTC by Anthony @ POW Games
Modified: 2020-12-18 05:20 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony @ POW Games 2020-12-17 16:51:31 UTC 
Oops, a recent change has broken SDL_ShowSimpleMessageBox. I'm passing SDL_MESSAGEBOX_ERROR, and it's causing an access violation at address 0x00000000. Doesn't matter what strings are passed or if it's attached to a window or a nullptr.
Comment 1 Ozkan Sezer 2020-12-17 18:03:13 UTC 
Recent ShowMessage changes are https://hg.libsdl.org/SDL/rev/155a6d4ff25d
and its follow-up https://hg.libsdl.org/SDL/rev/6044f03a6809

I tested on i686-Linux and os2, testmessage works. However, when built
for windows (mingw, tried today), testmessage.exe doesn't show anything.
Haven't investigated any further.

Can anyone see anything wrong with those commits? (I can not..)
Comment 2 Sam Lantinga 2020-12-17 18:59:24 UTC 
Ozkan, can you fix this for release?

Thanks!
Comment 3 Ozkan Sezer 2020-12-17 20:29:48 UTC 
Fixed by https://hg.libsdl.org/SDL/rev/3cdaf3321596
If not, please drop a note here. Closing.
Comment 4 Ozkan Sezer 2020-12-17 20:51:51 UTC 
Just pushed https://hg.libsdl.org/SDL/rev/9d71458fa504
Please test the tree as of this commit.
Comment 5 Anthony @ POW Games 2020-12-18 05:20:28 UTC 
I'm using VisualC project to build the DLL.

it's fixed now, thank-you.