We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5385 - CMake fails on Ubuntu: Unnecessary requirement of CMake 3.16 on non-Apple platforms
Summary: CMake fails on Ubuntu: Unnecessary requirement of CMake 3.16 on non-Apple pla...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P2 critical
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-09 09:18 UTC by Vitaly Novichkov
Modified: 2020-12-13 03:21 UTC (History)
1 user (show)

See Also:

Attachments
A CMake build fix (1.16 KB, patch)
2020-12-09 09:18 UTC, Vitaly Novichkov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Novichkov 2020-12-09 09:18:19 UTC 
Created attachment 4557 [details]
A CMake build fix

As was reported here https://bugzilla.libsdl.org/show_bug.cgi?id=5366#c10, the inclusion of `CheckOBJCSourceCompiles` makes require the CMake 3.16 and higher. This is an unnecessary change for non-Apple platforms where this inclusion is not used at all. I made the small fix that makes sure this include will be used on Apple platforms only. At the same time, the error message on CMake less than 3.16 was added. Probably, if CMake less than 3.16 on Apple platforms still needed, the workaround will be needed.
Comment 1 Sam Lantinga 2020-12-09 14:19:49 UTC 
That change was reverted in a different way. This should be fixed now, thanks!
https://hg.libsdl.org/SDL/rev/009f21e50409
Comment 2 Vitaly Novichkov 2020-12-10 08:46:48 UTC 
Fixed, thanks for a fix! :)
Comment 3 Sam Lantinga 2020-12-13 03:21:14 UTC 
You're welcome! :)