Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_OpenUrl disabled on iOS due to unified Xcode project file #3894

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

SDL_OpenUrl disabled on iOS due to unified Xcode project file #3894

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: iOS (All), iPhone/iPod touch

Comments on the original bug report:

On 2020-11-27 20:44:19 +0000, Dominik Reichardt wrote:

When you unified the Xcode project file you forgot to add the iOS file (/src/misc/ios/SDL_sysurl.m) to the project file, so the dummy in that folder takes over and the call does not work.

Relevant commits:
http://hg.libsdl.org/SDL/rev/d80e57b065b0 (SDL_OpenUrl enabled for macOS/iOS)

http://hg.libsdl.org/SDL/rev/316a289c79a3 (and following: unified Xcode project files)

Adding an ios group in the misc group of the project file and then adding /src/misc/ios/SDL_sysurl.m to it fixes the problem.

As it affects the project file and everything there is always weird I think it's better without a patch :)

I wonder if anything else got forgotten on the unification.

On 2020-11-28 19:38:57 +0000, Dominik Reichardt wrote:

Created attachment 4544
as disruptive as possible patch

On 2020-12-01 21:47:31 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/d0e4c35fa783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant