We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5367 - SDL_OpenUrl disabled on iOS due to unified Xcode project file
Summary: SDL_OpenUrl disabled on iOS due to unified Xcode project file
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.0
Hardware: iPhone/iPod touch iOS (All)
: P2 major
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-27 20:44 UTC by Dominik Reichardt
Modified: 2020-12-01 21:47 UTC (History)
0 users

See Also:

Attachments
as disruptive as possible patch (6.75 KB, patch)
2020-11-28 19:38 UTC, Dominik Reichardt 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Reichardt 2020-11-27 20:44:19 UTC 
When you unified the Xcode project file you forgot to add the iOS file (/src/misc/ios/SDL_sysurl.m) to the project file, so the dummy in that folder takes over and the call does not work.

Relevant commits:
http://hg.libsdl.org/SDL/rev/d80e57b065b0 (SDL_OpenUrl enabled for macOS/iOS)

http://hg.libsdl.org/SDL/rev/316a289c79a3 (and following: unified Xcode project files)

Adding an ios group in the misc group of the project file and then adding /src/misc/ios/SDL_sysurl.m to it fixes the problem.

As it affects the project file and everything there is always weird I think it's better without a patch :)

I wonder if anything else got forgotten on the unification.
Comment 1 Dominik Reichardt 2020-11-28 19:38:57 UTC 
Created attachment 4544 [details]
as disruptive as possible patch
Comment 2 Sam Lantinga 2020-12-01 21:47:31 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/d0e4c35fa783