We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5265 - [Patch] Redundant condition in KMSDRM_CreateCursor
Summary: [Patch] Redundant condition in KMSDRM_CreateCursor
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.13
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-19 10:43 UTC by Mathieu Eyraud
Modified: 2020-09-13 19:43 UTC (History)
1 user (show)

See Also:

Attachments
fix redundant condition (474 bytes, patch)
2020-08-19 10:43 UTC, Mathieu Eyraud 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Eyraud 2020-08-19 10:43:42 UTC 
Created attachment 4443 [details]
fix redundant condition

'usable_cursor_w == 0' is checked twice on line 117 in KMSDRM_CreateCursor in ksmdrmmouse.c.
Comment 1 Manuel Alfayate Corchete 2020-09-13 19:43:08 UTC 
@meyraud705: Thanks a lot for this! I have been looking at this code for so long in the last week that I couldn't see details on it anymore... :D
Patch merged!
Comment 2 Manuel Alfayate Corchete 2020-09-13 19:43:52 UTC 
Suggested patch applied.