We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5216 - Fix for modern Mesa OpenGL headers
Summary: Fix for modern Mesa OpenGL headers
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 1.2
Hardware: All All
: P2 normal
Assignee: Ozkan Sezer
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-27 05:36 UTC by Brad Smith
Modified: 2020-10-24 18:11 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Smith 2020-06-27 05:36:09 UTC 
The following diff which has been in our tree for a long time now to deal with modern Mesa OpenGL headers.

I don't know if it's the right way of doing things, but I am providing it for consideration.

http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/devel/sdl/patches/patch-include_SDL_opengl_h?rev=1.3&content-type=text/x-cvsweb-markup&hideattic=1
Comment 1 Ozkan Sezer 2020-06-27 08:55:04 UTC 
What's the issue with GL_ARB_shader_objects define?
Comment 2 Ozkan Sezer 2020-07-04 09:47:49 UTC 
Applied only the __gl_glext_h_ part of the patch for now:
https://hg.libsdl.org/SDL/rev/650db5cb7140

Will hold the GL_ARB_shader_objects part of the patch until
its relevance is clarified:  Brad?
Comment 3 Brad Smith 2020-07-04 23:53:18 UTC 
Thanks.

The other part of the diff at the time it was commited to our tree had a very vague commit message.

I will see about putting SDL through a bulk build minus that one piece and see if we can figure out what the actually fallout is.
Comment 4 Ozkan Sezer 2020-09-22 02:19:23 UTC 
(In reply to Brad Smith from comment #3)
> The other part of the diff at the time it was commited to our tree had a
> very vague commit message.
> 
> I will see about putting SDL through a bulk build minus that one piece and
> see if we can figure out what the actually fallout is.

No activity for about two months, so I'm closing this as fixed.

If the other part of the patch does really have merit, please
post a new patch.
Comment 5 Ozkan Sezer 2020-10-24 18:11:04 UTC 
Also applied this one: (regarding __gl_glext_h_ header guard)
https://hg.libsdl.org/SDL/rev/eca964040374