We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

I'll add the patches to Bugzilla soon, with a brief summary of them ("patch-aa", "patch-ab", etc isn't too descriptive).

Most look sane...many add #ifdef __DragonFly__ to places that check for BSD systems and are simple enough, others chew up configure.in quite a bit and need to be checked more closely.

However, they have split out the esound, arts, etc SDL audio drivers into seperate "plug-in" modules that are seperately packaged and dynamically loaded at runtime if they exist. This might be a leftover from before we added dynamic loading of libesd, etc into SDL itself...we should follow up with the NetBSD maintainers and see if we can get them to move to this and ditch the seperate packages.

--ryan.

(In reply to comment #1)
> I'll add the patches to Bugzilla soon, with a brief summary of them
> ("patch-aa", "patch-ab", etc isn't too descriptive).

Great!

> However, they have split out the esound, arts, etc SDL audio drivers into
> seperate "plug-in" modules that are seperately packaged and dynamically loaded
> at runtime if they exist. This might be a leftover from before we added dynamic
> loading of libesd, etc into SDL itself...we should follow up with the NetBSD
> maintainers and see if we can get them to move to this and ditch the seperate
> packages.

I agree.  Do we have a maintainer contact?

> Do we have a maintainer contact?

I don't, but I'm sure we can find one.

--ryan.

Setting Sam as "QA Contact" on all bugs (even resolved ones) so he'll definitely be in the loop to any further discussion here about SDL.

--ryan.

Ok, I sorted through these patches more thoroughly, and there's a handful of good patches...the DragonFly stuff refers to DragonFly BSD, which is a fork of FreeBSD 4...some of those patches would break existing FreeBSD code, or should at least be cleaned up so we don't have to check for DRAGONFLY || FREEBSD everywhere.

Also, it means that NetBSD probably lifted the patches wholesale from DragonFly, so that is another group/person we should contact.

A good portion of their patches were automake stuff that is either no longer valid, or non-trivial to reintegrate without a better understanding of why the changes are needed.

I'm committing the easy bits to CVS, and will track down the developers for integrating the rest...they'll need to do some heavy lifting to get some of these patches to match up to CVS again with the new build system, so they might as well do it once and have it go right into CVS from there.

--ryan.

Hold on, I have a dragonfly install now, I'm in the process of testing the patches. :)

Created attachment 86 [details]
Initial salvage...


Here's my cleaned-up patch for some good patches salvaged from the NetBSD package, against CVS.

I intentionally avoided all the Dragonfly stuff for now. This is just the non-controversial stuff.

--ryan.

(Whoops, didn't realize this was assigned to Sam, changing status back to "new" until he accepts it or tosses it to me.)

--ryan.

Most of the patches have been merged.

The dynamic nas, esd, and arts patches were not applied, since SDL already dynamically loads the esd and arts libraries at runtime, if available.  Hopefully the nas driver can be converted over to a similar mechanism.

Good idea, renaming OpenBSD audio to BSD audio.  I've applied that portion of your patch to CVS.