Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBSD patch evaluation #40

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

NetBSD patch evaluation #40

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 1.2
Reported for operating system, platform: NetBSD, x86

Comments on the original bug report:

On 2006-01-19 05:17:21 +0000, Sam Lantinga wrote:

We should look at the NetBSD patches and see if there are any worth adding to CVS.

On 2006-01-19 05:27:45 +0000, Ryan C. Gordon wrote:

I'll add the patches to Bugzilla soon, with a brief summary of them ("patch-aa", "patch-ab", etc isn't too descriptive).

Most look sane...many add #ifdef DragonFly to places that check for BSD systems and are simple enough, others chew up configure.in quite a bit and need to be checked more closely.

However, they have split out the esound, arts, etc SDL audio drivers into seperate "plug-in" modules that are seperately packaged and dynamically loaded at runtime if they exist. This might be a leftover from before we added dynamic loading of libesd, etc into SDL itself...we should follow up with the NetBSD maintainers and see if we can get them to move to this and ditch the seperate packages.

--ryan.

On 2006-01-19 05:33:21 +0000, Sam Lantinga wrote:

(In reply to comment # 1)

I'll add the patches to Bugzilla soon, with a brief summary of them
("patch-aa", "patch-ab", etc isn't too descriptive).

Great!

However, they have split out the esound, arts, etc SDL audio drivers into
seperate "plug-in" modules that are seperately packaged and dynamically loaded
at runtime if they exist. This might be a leftover from before we added dynamic
loading of libesd, etc into SDL itself...we should follow up with the NetBSD
maintainers and see if we can get them to move to this and ditch the seperate
packages.

I agree. Do we have a maintainer contact?

On 2006-01-19 05:34:48 +0000, Ryan C. Gordon wrote:

Do we have a maintainer contact?

I don't, but I'm sure we can find one.

--ryan.

On 2006-01-27 11:23:17 +0000, Ryan C. Gordon wrote:

Setting Sam as "QA Contact" on all bugs (even resolved ones) so he'll definitely be in the loop to any further discussion here about SDL.

--ryan.

On 2006-03-20 23:39:22 +0000, Ryan C. Gordon wrote:

Ok, I sorted through these patches more thoroughly, and there's a handful of good patches...the DragonFly stuff refers to DragonFly BSD, which is a fork of FreeBSD 4...some of those patches would break existing FreeBSD code, or should at least be cleaned up so we don't have to check for DRAGONFLY || FREEBSD everywhere.

Also, it means that NetBSD probably lifted the patches wholesale from DragonFly, so that is another group/person we should contact.

A good portion of their patches were automake stuff that is either no longer valid, or non-trivial to reintegrate without a better understanding of why the changes are needed.

I'm committing the easy bits to CVS, and will track down the developers for integrating the rest...they'll need to do some heavy lifting to get some of these patches to match up to CVS again with the new build system, so they might as well do it once and have it go right into CVS from there.

--ryan.

On 2006-03-20 23:44:02 +0000, Sam Lantinga wrote:

Hold on, I have a dragonfly install now, I'm in the process of testing the patches. :)

On 2006-03-21 00:14:34 +0000, Ryan C. Gordon wrote:

Created attachment 86
Initial salvage...

Here's my cleaned-up patch for some good patches salvaged from the NetBSD package, against CVS.

I intentionally avoided all the Dragonfly stuff for now. This is just the non-controversial stuff.

--ryan.

On 2006-03-21 00:15:38 +0000, Ryan C. Gordon wrote:

(Whoops, didn't realize this was assigned to Sam, changing status back to "new" until he accepts it or tosses it to me.)

--ryan.

On 2006-03-21 03:57:48 +0000, Sam Lantinga wrote:

Most of the patches have been merged.

The dynamic nas, esd, and arts patches were not applied, since SDL already dynamically loads the esd and arts libraries at runtime, if available. Hopefully the nas driver can be converted over to a similar mechanism.

On 2006-03-21 04:33:52 +0000, Sam Lantinga wrote:

Good idea, renaming OpenBSD audio to BSD audio. I've applied that portion of your patch to CVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant