We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5199 - [PATCH][KMSDRM] Fix KMSDRM_CreateWindow() segfault when starting LÖVE2D engine.
Summary: [PATCH][KMSDRM] Fix KMSDRM_CreateWindow() segfault when starting LÖVE2D engine.
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.1
Hardware: All Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-18 21:06 UTC by Manuel Alfayate Corchete
Modified: 2020-06-19 17:38 UTC (History)
0 users

See Also:

Attachments
Small patch that fixes KMSDRM_CreateWindow to avoid segfaults (1005 bytes, patch)
2020-06-18 21:06 UTC, Manuel Alfayate Corchete 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Alfayate Corchete 2020-06-18 21:06:46 UTC 
Created attachment 4389 [details]
Small patch that fixes KMSDRM_CreateWindow to avoid segfaults

Hi,

This small patch fixes the KMSDRM_CreateSurfaces() call in KMSDRM_CreateWindow(), that was segfaulting deeper into SDL internals because the windata->viddata pointer wasn't set before the KMSDRM_CreateSurfaces() call.
So that's what this small patch does.

Now, LÖVE2D works perfectly well on the Raspberry Pi 3, instead of just segfaulting.

Please merge.
Comment 1 Sam Lantinga 2020-06-19 17:38:09 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/fb6395c49ce9