We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5192 - [PATCH] Fix compile without DIRECTX
Summary: [PATCH] Fix compile without DIRECTX
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: 2.0.13
Hardware: x86 Windows 10
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-15 08:43 UTC by Dom
Modified: 2020-06-15 16:37 UTC (History)
0 users

See Also:

Attachments
Patch (1.58 KB, text/plain)
2020-06-15 08:43 UTC, Dom 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dom 2020-06-15 08:43:17 UTC 
Created attachment 4383 [details]
Patch

Compiling SDL without DIRECTX in cmake causes the following linker error in Visual Studio even when DirectX is unused:

LNK1104	cannot open file 'dxerr.lib'

Apparently dxerr was removed in Windows SDK 8.0 or higher as explained here: https://walbourn.github.io/wheres-dxerr-lib

This was fixed in SDL in 2008 as of https://hg.libsdl.org/SDL/rev/02aa80d7905f however some leftovers were not removed in cmake.

The attached patch fixes it.
Comment 1 Sam Lantinga 2020-06-15 16:37:28 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/348d0896fc9e