We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5175 - SDL_fcitx.c: CMake build failed: unknown type name ‘SDL_DBusContext’
Summary: SDL_fcitx.c: CMake build failed: unknown type name ‘SDL_DBusContext’
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P2 critical
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.14
Depends on:
Blocks:
 
Reported: 2020-06-05 08:44 UTC by Vitaly Novichkov
Modified: 2020-06-26 21:43 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Novichkov 2020-06-05 08:44:36 UTC 
Once upon I updated one of my projects and I got the failure of CI builds with a recent state of SDL2 HG top.

https://travis-ci.org/github/WohlSoft/AudioCodecs/jobs/694942604#L1438
https://semaphoreci.com/wohlstand/audiocodecs/branches/master/builds/276

```
/home/travis/build/WohlSoft/AudioCodecs/build/external/SDL2/src/SDL2HG/src/core/linux/SDL_fcitx.c:47:5: error: unknown type name ‘SDL_DBusContext’

     SDL_DBusContext *dbus;

     ^

/home/travis/build/WohlSoft/AudioCodecs/build/external/SDL2/src/SDL2HG/src/core/linux/SDL_fcitx.c:87:31: error: unknown type name ‘SDL_DBusContext’

 size_t Fcitx_GetPreeditString(SDL_DBusContext *dbus, DBusMessage *msg, char **ret) {

                               ^

/home/travis/build/WohlSoft/AudioCodecs/build/external/SDL2/src/SDL2HG/src/core/linux/SDL_fcitx.c:87:54: error: unknown type name ‘DBusMessage’

 size_t Fcitx_GetPreeditString(SDL_DBusContext *dbus, DBusMessage *msg, char **ret) {

                                                      ^

/home/travis/build/WohlSoft/AudioCodecs/build/external/SDL2/src/SDL2HG/src/core/linux/SDL_fcitx.c:136:1: error: unknown type name ‘DBusHandlerResult’

 DBus_MessageFilter(DBusConnection *conn, DBusMessage *msg, void *data)

...


```
Comment 1 Sam Lantinga 2020-06-05 19:34:11 UTC 
Ryan, the FCITX code assumes dbus support. Can you fix that?
Comment 2 Ryan C. Gordon 2020-06-26 21:43:44 UTC 
This _should_ be fixed in https://hg.libsdl.org/SDL/rev/e545192f60f1 ...CMake was including all the src/core/linux/*.c files, whereas configure was including them individually where it needed to.

--ryan.