We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5146 - SDL_RenderFillRect doesn't work in DirectFB
Summary: SDL_RenderFillRect doesn't work in DirectFB
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.12
Hardware: ARM Linux
: P2 major
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-19 11:40 UTC by Lacky
Modified: 2020-05-29 23:03 UTC (History)
0 users

See Also:

Attachments
Fix SDL_RenderFillRect for DirectFB (282 bytes, patch)
2020-05-19 11:40 UTC, Lacky 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lacky 2020-05-19 11:40:02 UTC 
Created attachment 4348 [details]
Fix SDL_RenderFillRect for DirectFB

It looks like refactoring of SDL2 internal API has broken SDL_RenderFillRect for DirectFB. In new version function SDL_RenderFillRect returns 0, but rectangle is not visible.

Replacing "count" with "len" in the argument list for SDL_memcpy in DirectFB_QueueFillRects fixes problem.

In attachment is my proposition of patch.
Comment 1 Sam Lantinga 2020-05-29 23:03:13 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/a90089f75990