We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5111 - [PATCH] Xbox One Bluetooth controllers aren't picked up by HIDAPI on macOS
Summary: [PATCH] Xbox One Bluetooth controllers aren't picked up by HIDAPI on macOS
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: x86 macOS 10.15
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-26 02:28 UTC by Cameron Gutman
Modified: 2020-06-03 00:05 UTC (History)
0 users

See Also:

Attachments
Enable Xbox One HIDAPI driver on macOS (994 bytes, patch)
2020-04-26 02:29 UTC, Cameron Gutman 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Gutman 2020-04-26 02:28:03 UTC 
Xbox One S Bluetooth controllers are getting picked up by the regular IOKit joystick support on macOS rather than HIDAPI. The HIDAPI driver is required to enable force feedback and correct the button mapping on the 4.8 controller firmware.

The Xbox One HIDAPI driver was disabled on macOS because at the time the Xbox 360 driver handled all Xbox One controllers. Since then, Xbox One support in HIDAPI has been significantly refactored (https://hg.libsdl.org/SDL/rev/2c4ec356333e) and the Xbox One HIDAPI driver is now required on macOS for Bluetooth Xbox One S controller support.
Comment 1 Cameron Gutman 2020-04-26 02:29:06 UTC 
Created attachment 4322 [details]
Enable Xbox One HIDAPI driver on macOS
Comment 2 Cameron Gutman 2020-05-31 18:34:31 UTC 
Bumping for review.

This has been shipping in Moonlight for a bit over a month. No problems reported.
Comment 3 Sam Lantinga 2020-06-03 00:05:16 UTC 
Added, thanks!
https://hg.libsdl.org/SDL/rev/fcc95c568261