We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5103 - Port fcitx support to both fcitx 4 & 5
Summary: Port fcitx support to both fcitx 4 & 5
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-22 08:36 UTC by wengxt
Modified: 2020-05-11 21:31 UTC (History)
1 user (show)

See Also:

Attachments
Patch to support fcitx 5 (17.75 KB, patch)
2020-04-22 08:36 UTC, wengxt 		Details | Diff
Update the patch to support build with cmake (18.69 KB, patch)
2020-05-11 04:47 UTC, wengxt 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wengxt 2020-04-22 08:36:49 UTC 
Created attachment 4318 [details]
Patch to support fcitx 5

Due to the new major fcitx version is coming close, the existing code need to be ported to use new Fcitx dbus interface.

The new dbus interface is supported by both fcitx 4 and 5, and has a good side effect, which is that it will work with flatpak for free. Also the patch remove the dependency on fcitx header. Instead, it just hardcodes a few enum value in the code so need to handle the different header for fcitx4 or 5.
Comment 1 Jerry Xiao 2020-05-10 03:25:56 UTC 
(In reply to wengxt from comment #0)
> Created attachment 4318 [details]
> Patch to support fcitx 5
> 
> Due to the new major fcitx version is coming close, the existing code need
> to be ported to use new Fcitx dbus interface.
> 
> The new dbus interface is supported by both fcitx 4 and 5, and has a good
> side effect, which is that it will work with flatpak for free. Also the
> patch remove the dependency on fcitx header. Instead, it just hardcodes a
> few enum value in the code so need to handle the different header for fcitx4
> or 5.

Nice job!
Comment 2 wengxt 2020-05-11 04:47:37 UTC 
Created attachment 4337 [details]
Update the patch to support build with cmake
Comment 3 Sam Lantinga 2020-05-11 21:31:29 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/a73b49512ba2