We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5098 - macOS CreateWindowFrom doesn't work with high-dpi displays
Summary: macOS CreateWindowFrom doesn't work with high-dpi displays
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: 2.0.13
Hardware: All Mac OS X (All)
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-19 02:39 UTC by michaeljosephmaltese
Modified: 2020-05-11 21:36 UTC (History)
0 users

See Also:

Attachments
[PATCH] cocoa: ask for highdpi surface in CreateWindowFrom (1.10 KB, text/plain)
2020-04-19 02:39 UTC, michaeljosephmaltese 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description michaeljosephmaltese 2020-04-19 02:39:00 UTC 
Created attachment 4311 [details]
[PATCH] cocoa: ask for highdpi surface in CreateWindowFrom

Display ends up taking only 1/4 of the screen area. It needs to call "setWantsBestResolutionOpenGLSurface:highdpi", like when creating a window the normal way.
Comment 1 michaeljosephmaltese 2020-05-08 20:32:52 UTC 
Any updates on this? This directly impacts the use of https://bugzilla.libsdl.org/show_bug.cgi?id=5060 , which is marked as target-2.0.14.

Happy to work on the patch more if you'd like anything changed.
Comment 2 Sam Lantinga 2020-05-11 21:36:50 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/ccd76043c80e