We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 506 - r3439 seems to have broken the Pingus music
Summary: r3439 seems to have broken the Pingus music
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-21 07:29 UTC by Torbjörn Andersson
Modified: 2009-10-04 23:56 UTC (History)
0 users

See Also:

Attachments
MOD which sounds wrong with Brandon's patch (126.46 KB, application/octet-stream)
2009-10-04 22:56 UTC, Sam Lantinga 		Details
Patch for libmikmod fixing both this bug and Brandon's crash (3.10 KB, patch)
2009-10-04 23:56 UTC, Sam Lantinga 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torbjörn Andersson 2007-10-21 07:29:24 UTC 
It seems that revision 3439 [1] of SDL_mixer broke the music from Pingus 0.7.1 [2].

[1] http://lists.libsdl.org/pipermail/svn-libsdl.org/2007-August/000491.html
[2] http://pingus.seul.org/download.html

I noticed it first with data/music/pingus-1.it, which sounds all wrong. Reverting the change to pt_UpdateVoices() "fixes" it, but presumably re-introduces the bug that revision 3439 was supposed to fix. I'm afraid I don't have any ideas for how to fix it properly.
Comment 1 Sam Lantinga 2009-10-03 02:13:56 UTC 
I upgraded libmikmod to version 3.1.12 and reverted the patch which caused this bug, which was fixing the following bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=422021

I've sent e-mail to Brandon, who submitted that patch to see if his bug is fixed by the libmikmod upgrade.
Comment 2 Sam Lantinga 2009-10-04 22:53:41 UTC 
Brandon wrote back with more information on the debian bug:

The newest version of libmikmod still has the bug I reported and made a
patch for.
http://sourceforge.net/tracker/?func=detail&aid=1630158&group_id=40531&atid=428227
So if you upgraded libmikmod, and removed my patch, then SDL-mixer
would most likely again suffer from this bug.

I would be happy to help you out. I need to know which libraries I need
for the above functions.

If you want to try to duplicate this yourself:
1) download and build an older version of penguin command:
http://prdownloads.sourceforge.net/penguin-command/penguin-command-1.6.10.tar.gz
2) run penguin command with the SDL mixer library you want to test

It should segfault 1/4 times on boot. Specifically, whenever
pennight.mod plays, it should segfault. If you were to continue to play
the game, then eventually it should segfault when the music eventually
transitions to pennight.mod.
Comment 3 Sam Lantinga 2009-10-04 22:56:51 UTC 
Created attachment 396 [details]
MOD which sounds wrong with Brandon's patch

I verified that this MOD will not sound correct if Brandon's patch is applied.  The pf->numchn is set to 8, but by the end of the song there are 41 voices playing.
Comment 4 Sam Lantinga 2009-10-04 23:56:49 UTC 
Created attachment 397 [details]
Patch for libmikmod fixing both this bug and Brandon's crash

Okay, I tracked down the issue and have a patch for libmikmod that solves both this bug and the crash Brandon was trying to fix.