We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5056 - Build is broken with directfb
Summary: Build is broken with directfb
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: 2.0.12
Hardware: All Linux
: P2 major
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-24 13:04 UTC by Fabrice Fontaine
Modified: 2020-12-20 20:40 UTC (History)
2 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2020-03-24 13:04 UTC, Fabrice Fontaine 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabrice Fontaine 2020-03-24 13:04:22 UTC 
Created attachment 4277 [details]
Patch

Build with directfb is broken due to a spurious '}' and a missing 'E'
since version 2.0.12 and
https://github.com/spurious/SDL-mirror/commit/7328bbad9e74f783ce25392eb2d849b68f78a37e:

/home/buildroot/autobuild/run/instance-2/output-1/build/sdl2-2.0.12/src/video/directfb/SDL_DirectFB_render.c: In function 'SetBlendMode':
/home/buildroot/autobuild/run/instance-2/output-1/build/sdl2-2.0.12/src/video/directfb/SDL_DirectFB_render.c:202:9: error: case label not within a switch statement
  202 |         case SDL_BLENDMODE_MUL:
      |         ^~~~

/home/buildroot/autobuild/run/instance-2/output-1/build/sdl2-2.0.12/src/video/directfb/SDL_DirectFB_render.c:205:67: error: 'DSBF_DSTCOLOR' undeclared (first use in this function); did you mean 'DSBF_DESTCOLOR'?
  205 |             SDL_DFB_CHECK(destsurf->SetSrcBlendFunction(destsurf, DSBF_DSTCOLOR));
      |                                                                   ^~~~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/83ccefee68c2800c0544e6f40fa8bc8ee6b67b77
Comment 1 Sam Lantinga 2020-03-24 17:06:20 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/769f80095217
Comment 2 nuclearfall 2020-12-03 19:01:32 UTC 
Just did a wget today for SDL2-2.0.12 and this bug is still present.
Comment 3 Sam Lantinga 2020-12-05 11:41:36 UTC 
Can you check the latest snapshot?
http://www.libsdl.org/tmp/SDL-2.0.zip
Comment 4 Ozkan Sezer 2020-12-20 20:40:53 UTC 
I can build with directfb enabled, so this seems to have been
fixed for 2.0.14. Closing.