We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

When I call SDL_GameControllerSetPlayerIndex() to set a gamepad to a player index that it happens to already be using, the result is that the gamepad is moved to a new player index that isn't the one I requested.

Reproducer:
SDL_GameControllerSetPlayerIndex(controller, 0);
SDL_GameControllerSetPlayerIndex(controller, 0);

The problem is that we hit the following code:
    /* Move any existing joystick to another slot */
    if (existing_instance >= 0) {
        SDL_SetJoystickIDForPlayerIndex(SDL_FindFreePlayerIndex(), existing_instance);
    }

However, existing_instance == instance_id at that time, so we end up moving the joystick again. We can detect this case earlier to avoid this issue.