We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 5005 - [patch] warnings in kmsdrm
Summary: [patch] warnings in kmsdrm
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 2.0
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-25 20:46 UTC by Malte Kießling
Modified: 2020-02-27 16:20 UTC (History)
0 users

See Also:

Attachments
patch (1.31 KB, patch)
2020-02-25 20:46 UTC, Malte Kießling 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malte Kießling 2020-02-25 20:46:28 UTC 
Created attachment 4228 [details]
patch

At the moment i get following warnings from kmsdrm: 

 * in SDL_kmsdrmvideo.c KMSDRM_DestroySurfaces is return type int, but thats never returned or checked against 
 * in SDL_kmsdrmvideo.c KMSDRM_DestroySurfaces the variable viddata is not used
 * in SDL_kmsdrmopengles.c KMSDRM_GLES_LoadLibrary a cast to NativeDisplayType is missing

I attached a patch for them :) 
I think changing KMSDRM_DestroySurfaces to void is ok? Its not used anywhere else and its a quite recent addition if i read the commit logs right. 

~mkalte
Comment 1 Sam Lantinga 2020-02-27 16:20:51 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/936b1869a34a