You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can be reproduced on Linux when shaders are deactivated.
On 2020-03-20 20:47:32 +0000, Ryan C. Gordon wrote:
So this is cached state, so if we're turning it on and off, we need to check/update:
GL_RenderData::drawstate.texturing
It looks like several places (not just SDL_UpdateTexture) enable and disable it. This is likely a holdover from before we were aggressively caching state.
I need to go back and read up on the legacy rules of GL_TEXTURE_2D...I suspect we don't need to enable it every time we bind a texture, but only when drawing with one, which would mean the correct thing to do is remove all these enable/disable calls outside of the one in SetDrawState().
--ryan.
On 2020-03-22 18:34:03 +0000, Ryan C. Gordon wrote:
Ok, this is fixed by https://hg.libsdl.org/SDL/rev/1c73cc1e4a3a ...we don't need to enable GL_TEXTURE_* to change texture state, just to enable texturing during rendering.
--ryan.
The text was updated successfully, but these errors were encountered:
This bug report was migrated from our old Bugzilla tracker.
Reported in version: HG 2.1
Reported for operating system, platform: AmigaOS, PowerPC
Comments on the original bug report:
On 2020-02-21 08:10:59 +0000, Juha Niemimäki wrote:
On 2020-03-20 20:47:32 +0000, Ryan C. Gordon wrote:
On 2020-03-22 18:34:03 +0000, Ryan C. Gordon wrote:
The text was updated successfully, but these errors were encountered: