We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4944 - fbdev: Double-buffering with non-fullscreen resolution
Summary: fbdev: Double-buffering with non-fullscreen resolution
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: video (show other bugs)
Version: HG 1.2
Hardware: All Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-13 18:14 UTC by Paul Cercueil
Modified: 2020-09-22 02:08 UTC (History)
1 user (show)

See Also:

Attachments
Patch to fix the issue (1.46 KB, text/plain)
2020-01-13 18:14 UTC, Paul Cercueil 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Cercueil 2020-01-13 18:14:59 UTC 
Created attachment 4160 [details]
Patch to fix the issue

From the patch:

"If an exact resolution match is not found, SDL will accept a higher
resolution and add black bars around it. For example, when 320x200 is
requested by only 320x240 is available, it will add 20 black lines on
the top and the bottom of the screen. The surface that SDL returns to
the application will look like it actually got 320x200.

When double buffering, the actual video mode's height should be used
instead of the height before adding the black borders. For the pixel
pointer this was done correctly, but for the vertical panning offset
the wrong height was used."
Comment 1 Ozkan Sezer 2020-09-22 02:08:33 UTC 
The patch is in. Thanks.
http://hg.libsdl.org/SDL/rev/6097967fb3b4