Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wl_data_device_manager bind is missing version check #3500

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

wl_data_device_manager bind is missing version check #3500

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2020-01-03 02:08:46 +0000, Michael Forney wrote:

Created attachment 4146
Patch fixing the issue

When the wayland video driver sees a wl_data_device_manager global, it binds it as version 3, even if that is newer than the version supported by the compositor. This will result in a protocol error, even though SDL could continue if the global was not even present.

Attached is a patch to fix the issue.

On 2020-01-03 06:39:54 +0000, Michael Forney wrote:

Created attachment 4147
Alternative patch to support wl_data_device_manager < 3

I attached another patch as an alternative which supports wl_data_device_manager versions 1 and 2 by making the wl_data_offer_set_actions request conditional on the version being >= 3.

On 2020-01-03 22:24:30 +0000, Sam Lantinga wrote:

Your second patch is in, thanks!
https://hg.libsdl.org/SDL/rev/d984274996dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant