We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4912 - error: 'SDL_Joystick {aka struct _SDL_Joystick}' has no member named 'player_index'
Summary: error: 'SDL_Joystick {aka struct _SDL_Joystick}' has no member named 'player_...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.1
Hardware: x86_64 Windows (All)
: P2 blocker
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-22 12:51 UTC by Konrad
Modified: 2019-12-22 21:43 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad 2019-12-22 12:51:31 UTC 
Recent commits from Sam caused critical bug on Windows:

[ 29%] Building C object CMakeFiles/SDL2-static.dir/src/joystick/windows/SDL_xinputjoystick.c.obj
C:\Users\Konrad\Desktop\SDL2\src\joystick\windows\SDL_xinputjoystick.c: In function 'SDL_XINPUT_JoystickOpen':
C:\Users\Konrad\Desktop\SDL2\src\joystick\windows\SDL_xinputjoystick.c:347:13: error: 'SDL_Joystick {aka struct _SDL_Joystick}' has no member named 'player_index'
     joystick->player_index = userId;
             ^~
make[2]: *** [CMakeFiles/SDL2-static.dir/src/joystick/windows/SDL_xinputjoystick.c.obj] Error 1
make[1]: *** [CMakeFiles/SDL2-static.dir/all] Error 2
make: *** [all] Error 2
Comment 1 Ozkan Sezer 2019-12-22 21:43:01 UTC 
This should be fixed by https://hg.libsdl.org/SDL/rev/5ee53104caed