This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Patch - music_flac.c and music.ogg.c - add support for play count when looping (music_flac_and_ogg_play_count.patch, text/plain, 2019-11-24 03:09:04 +0000, 1791 bytes)
• Sample looping file (Тест, тест, 123.ogg, video/ogg, 2019-11-26 10:42:52 +0000, 44486 bytes)
• A short demo of patched result, recorded on the video (2019-11-26_13-30-00.mkv, video/x-matroska, 2019-11-26 10:44:04 +0000, 734112 bytes)

Reported in version: 2.0.4
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2019-11-24 03:09:04 +0000, Michael Day wrote:

Created attachment 4068
Patch - music_flac.c and music.ogg.c - add support for play count when looping

When looping using loop points specified by LOOP* metadata tags, the looping logic should be affected by the user-specified play count value. The patch here applies uniform looping logic to both music_ogg.c and music_flac.c. Also, when the play count is 1, we want to play the audio file straight through without any looping. (This is not currently how the looping logic behaves.)

On 2019-11-24 11:36:33 +0000, Ozkan Sezer wrote:

Vitaly: This touches your patched code too, I think. So review/test.

On 2019-11-26 10:25:28 +0000, Vitaly Novichkov wrote:

Gonna to check out the thing...

On 2019-11-26 10:42:23 +0000, Vitaly Novichkov wrote:

I have tested this patch, and it fixes the bug! When the file is looping, and when is limited loops count set, the tail should be played after all loops were passed to finalize the song. So, now there are playing fine!

On 2019-11-26 10:42:52 +0000, Vitaly Novichkov wrote:

Created attachment 4069
Sample looping file

A short sample file to verify the looping

On 2019-11-26 10:44:04 +0000, Vitaly Novichkov wrote:

Created attachment 4070
A short demo of patched result, recorded on the video

Here you'll see the seek bar. The blue area is the loop range.
I did next tests:

• forever looping
• play single time
• loop twice
• loop trice

On 2019-11-26 11:38:33 +0000, Ozkan Sezer wrote:

Patch applied: http://hg.libsdl.org/SDL_mixer/rev/4f9f5e59419a
Thanks.