We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4857 - OGG Vorbis: Handle loop tags limit
Summary: OGG Vorbis: Handle loop tags limit
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-12 09:36 UTC by Vitaly Novichkov
Modified: 2019-11-17 07:39 UTC (History)
1 user (show)

See Also:

Attachments
A patch that adds loops count limit handling for looping OGGs (1.22 KB, patch)
2019-11-12 09:36 UTC, Vitaly Novichkov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Novichkov 2019-11-12 09:36:07 UTC 
Created attachment 4042 [details]
A patch that adds loops count limit handling for looping OGGs

Some years ago I have fixed OGG looping with using limited loops count. With the current code, the looping OGG file will be played forever even you don't want that. So, with this patch, if you want to loop forever, it will do. However, if you don't want to loop more than X times, it will don't.

https://github.com/WohlSoft/SDL-Mixer-X/commit/a67d8fd0b061c75d3f50f4620a57275df61f3eb4#r35908834
Comment 1 Sam Lantinga 2019-11-17 06:14:15 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL_mixer/rev/e134ad064126
Comment 2 Ozkan Sezer 2019-11-17 07:39:17 UTC 
Is something like this needed for the newly added flac loop
support too? (see bug #4855.)