We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4853 - music_ogg.c: revise parsing loop info
Summary: music_ogg.c: revise parsing loop info
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Ozkan Sezer
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-05 12:39 UTC by Ozkan Sezer
Modified: 2019-11-10 20:03 UTC (History)
1 user (show)

See Also:

Attachments
str_to_int64.patch (3.10 KB, patch)
2019-11-05 12:39 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2019-11-05 12:39:06 UTC 
Created attachment 4038 [details]
str_to_int64.patch

According to Vitaly Novichkov [1], there are broken vorbis files in the
wild which has bad looping info with leading and/or trailing non-digits
that fool strtoull() [2] [3].  The attached patch is based on code from
his SDL_mixer-X fork [1].  OK to apply?

[1] https://github.com/WohlSoft/SDL-Mixer-X/commit/a67d8fd0b061c75d3f50f4620a57275df61f3eb4#comments
[2] https://github.com/WohlSoft/SDL-Mixer-X/files/3808096/Not.So.Heavenly.Boss.Battle.ogg.zip
[3] https://github.com/WohlSoft/SDL-Mixer-X/files/3808099/Not.So.Heavenly.Preparation.Room.ogg.zip
Comment 1 Sam Lantinga 2019-11-10 19:52:31 UTC 
Yep, that's fine, thanks!
Comment 2 Ozkan Sezer 2019-11-10 20:03:41 UTC 
Patch applied: http://hg.libsdl.org/SDL_mixer/rev/b2b18baf65d9
Closing.