We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4849 - [PATCH] Expand OGG looping support
Summary: [PATCH] Expand OGG looping support
Status: RESOLVED FIXED
Alias: None
Product: SDL_mixer
Classification: Unclassified
Component: misc (show other bugs)
Version: 2.0.4
Hardware: x86 Other
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-30 03:19 UTC by Michael Day
Modified: 2019-11-01 17:38 UTC (History)
0 users

See Also:

Attachments
Patch file for music_ogg.c to expand looping support (2.69 KB, patch)
2019-10-30 03:19 UTC, Michael Day 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Day 2019-10-30 03:19:54 UTC 
Created attachment 4025 [details]
Patch file for music_ogg.c to expand looping support

Attached is a patch for music_ogg.c which offers two improvements to the built-in OGG looping:

1. Valid tag/comment key names currently take the form of LOOPxxx. Add support for LOOP_xxx and LOOP-xxx as well.
2. Add support for loop points specified by time strings of the form HH:MM:SS.ss.

The impetus for this change is to help improve music looping for Doom source ports which expect users to use music files with tags based on the tag standard established by ZDoom. (See https://zdoom.org/wiki/Audio_loop)
Comment 1 Sam Lantinga 2019-11-01 17:38:22 UTC 
This patch is in, thanks!
https://hg.libsdl.org/SDL_mixer/rev/493a943d944a