We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4842 - Redundant condition in MS_ADPCM_Decode and IMA_ADPCM_Decode
Summary: Redundant condition in MS_ADPCM_Decode and IMA_ADPCM_Decode
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: audio (show other bugs)
Version: 2.0.10
Hardware: All All
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-21 11:57 UTC by Mathieu Eyraud
Modified: 2019-10-23 07:38 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Eyraud 2019-10-21 11:57:44 UTC 
In file src/audio/SDL_wave.c on line 720 and 1117, 'file->trunchint == TruncVeryStrict' is checked twice. I guess one should be TruncStrict instead of TruncVeryStrict.
Comment 1 Sylvain 2019-10-23 07:38:31 UTC 
Thanks, indeed seems a typo, 
Fixed in https://hg.libsdl.org/SDL/rev/26581b48aef9
but I will re-opened bug 3894 - Fuzzing crashes for SDL_LoadWAV
so that it's double checked