Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No restore event is emitted after unminimize #3417

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

No restore event is emitted after unminimize #3417

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 2.0.10
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2019-10-08 19:59:13 +0000, ryven wrote:

At least on X11, no SDL_WINDOWEVENT_RESTORED event is emitted after the window was unminimized.

This was caused by this commit:
SDL-mirror/SDL@abcfcda

Reason:
In X11_DispathEvent on PropertyNotify on _NET_WM_STATE property change, if unminimized is happens, X11_DispatchMapNotify is called:
https://github.com/SDL-mirror/SDL/blob/master/src/video/x11/SDL_x11events.c#L1295

X11_DispatchMapNotify tries to emit two events:

On 2019-12-02 15:46:31 +0000, Alex Smith wrote:

I ran into this issue today. The attached patch fixes it for me.

On 2019-12-02 15:47:05 +0000, Alex Smith wrote:

Created attachment 4085
Patch to fix the issue.

On 2019-12-04 05:56:19 +0000, Sam Lantinga wrote:

Looks good, thanks!
https://hg.libsdl.org/SDL/rev/81ca537d1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant