We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4755 - [Patch] Fix setlocale issues in libusb hid.c
Summary: [Patch] Fix setlocale issues in libusb hid.c
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: All All
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-07 03:12 UTC by Ethan Lee
Modified: 2019-08-07 06:08 UTC (History)
0 users

See Also:

Attachments
Fix setlocale issues in libusb hid.c (1.60 KB, patch)
2019-08-07 03:12 UTC, Ethan Lee 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ethan Lee 2019-08-07 03:12:46 UTC 
Created attachment 3922 [details]
Fix setlocale issues in libusb hid.c

Not much to see here, just including a header that I should have included in the first place~

In addition to fixing the WIN32 TODO it also fixes some of the buildbot builds that had the same error. Kind of obvious in hindsight.

On that subject, the buildbot VMs may need to add libusb-devel files to get full test coverage for this feature.
Comment 1 Sam Lantinga 2019-08-07 06:08:04 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/200f23b4f8d2