We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4751 - SDL_x11xinput2.c: Build was broken by commit bbbb30026158 with a silly mistake
Summary: SDL_x11xinput2.c: Build was broken by commit bbbb30026158 with a silly mistake
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86_64 Linux
: P1 critical
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-02 21:57 UTC by Vitaly Novichkov
Modified: 2019-08-04 20:42 UTC (History)
1 user (show)

See Also:

Attachments
A screenshot with a build error I have met (119.60 KB, image/png)
2019-08-02 21:57 UTC, Vitaly Novichkov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Novichkov 2019-08-02 21:57:06 UTC 
Created attachment 3918 [details]
A screenshot with a build error I have met

This commit (https://hg.libsdl.org/SDL/rev/bbbb30026158) breaks the build on Linux

In src/video/x11/SDL_x11xinput2.c
--------------------------------------------------------------
SDL_SendTouchMotion(xev->sourceid,xev->detail, /* FIXME: window */, x, y, 1.0);
--------------------------------------------------------------

Lol, who commented an argument of function without providing an alternative constant as a dummy?

In fact, the line now is:
--------------------------------------------------------------
SDL_SendTouchMotion(xev->sourceid,xev->detail, , x, y, 1.0);
--------------------------------------------------------------

Maybe pass NULL?
--------------------------------------------------------------
SDL_SendTouchMotion(xev->sourceid,xev->detail, /* FIXME: window */ NULL, x, y, 1.0);
--------------------------------------------------------------

Otherwise, the whole build is BROKEN...
Comment 1 Alex Szpakowski 2019-08-03 14:26:24 UTC 
The intention was to break the build until someone can update the code to pass in a real SDL_Window*, since passing in null isn't really valid.
Comment 2 Alex Szpakowski 2019-08-04 20:03:16 UTC 
SDL should no longer fail to compile due to touch-related code as of https://hg.libsdl.org/SDL/rev/b4a7e94357f2 .
Comment 3 Vitaly Novichkov 2019-08-04 20:42:03 UTC 
Just now I have checked, and it works! Thank you for a fix!