We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4742 - SDL 2.0.10 DMG has duplicated files (instead of symlinks)
Summary: SDL 2.0.10 DMG has duplicated files (instead of symlinks)
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: 2.0.10
Hardware: x86_64 Mac OS X (All)
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.12
Depends on:
Blocks:
 
Reported: 2019-07-26 20:56 UTC by Cameron Gutman
Modified: 2019-09-20 20:48 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Gutman 2019-07-26 20:56:58 UTC 
Inside SDL2.framework in the official 2.0.10 DMG, it looks like several symlinks got broken during the build and were replaced with duplicates of all the files that would be accessed via the symlinks.

The following symlinks are broken in this way:
SDL2.framework/Headers -> SDL2.framework/Versions/Current/Headers
SDL2.framework/Resources -> SDL2.framework/Versions/Current/Resources
SDL2.framework/Versions/Current -> SDL2.framework/Versions/A

There are 3 complete copies of the headers in SDL2.framework: SDL2.framework/Headers, SDL2.framework/Versions/Current/Headers, and SDL2.framework/Versions/A/Headers.

Similarly there are 3 copies of the actual SDL2 Mach-O binary in SDL2.framework/SDL2, SDL2.framework/Versions/Current/SDL2, and SDL2.framework/Versions/A/SDL2

The 2.0.10 DMG is noticeably larger than 2.0.9 as a result:
-rw-r--r--@ 1 cgutman  staff   3.8M Jul 26 10:11 SDL2-2.0.10.dmg
-rw-r--r--@ 1 cgutman  staff   994K Nov  3  2018 SDL2-2.0.9.dmg

I don't remember if this was the case for the pre-release and I don't have a copy laying around to check. I don't think I used the DMG during pre-release testing due to the initial bug where the SDL2.framework was missing completely.
Comment 1 Ozkan Sezer 2019-07-26 21:32:30 UTC 
Unrelated (&& minor) but SDL_REVISION_NUMBER in SDL_revision.h is wrong too:
It is set to 12952, but https://hg.libsdl.org/SDL/rev/bc90ce38f1e2 is 12951.
2.0.9 release was correct for it.
Comment 2 Sam Lantinga 2019-07-30 17:22:48 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/5b007d665d04

I've rebuilt the release DMG with this fix as well.
Comment 3 Ryan C. Gordon 2019-07-30 17:49:38 UTC 
(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.
Comment 4 Ryan C. Gordon 2019-09-20 20:47:38 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 5 Ryan C. Gordon 2019-09-20 20:48:44 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.