We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4737 - [PATCH] cmake: Fix locating libusb header at configure-time
Summary: [PATCH] cmake: Fix locating libusb header at configure-time
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: HG 2.0
Hardware: x86_64 Linux
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.12
Depends on:
Blocks:
 
Reported: 2019-07-25 13:10 UTC by Andrew Eikum
Modified: 2019-09-20 20:48 UTC (History)
2 users (show)

See Also:

Attachments
[PATCH] cmake: Fix locating libusb header at configure-time (1.33 KB, patch)
2019-07-25 13:10 UTC, Andrew Eikum 		Details | Diff
[PATCH] cmake: Fix locating libusb header at configure-time (1.33 KB, patch)
2019-07-31 16:35 UTC, Andrew Eikum 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eikum 2019-07-25 13:10:25 UTC 
Created attachment 3895 [details]
[PATCH] cmake: Fix locating libusb header at configure-time

On my system, libusb's header detection failed, because it needs a -I flag. We should pass this in from pkg-config. However, the earlier check for the libusb header in the BSD section would cache the failure, so this patch also makes that check BSD-only.
Comment 1 Ryan C. Gordon 2019-07-30 17:49:38 UTC 
(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.
Comment 2 Ethan Lee 2019-07-30 18:12:16 UTC 
This patch worked for me after changing the "or"s to "OR".
Comment 3 Andrew Eikum 2019-07-31 16:35:10 UTC 
Created attachment 3914 [details]
[PATCH] cmake: Fix locating libusb header at configure-time

New version that fixes the 'or' casing.
Comment 4 Sam Lantinga 2019-07-31 17:13:01 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/2fbd3d8432ab
Comment 5 Ryan C. Gordon 2019-09-20 20:47:35 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 6 Ryan C. Gordon 2019-09-20 20:48:44 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.