We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4717 - allow linking / dlopening libwebpdecoder instead of libwebp
Summary: allow linking / dlopening libwebpdecoder instead of libwebp
Status: RESOLVED FIXED
Alias: None
Product: SDL_image
Classification: Unclassified
Component: misc (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Assignee: Ozkan Sezer
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-11 17:38 UTC by Ozkan Sezer
Modified: 2020-12-21 21:17 UTC (History)
0 users

See Also:

Attachments
patch for SDL2_image (2.17 KB, patch)
2019-07-11 17:38 UTC, Ozkan Sezer 		Details | Diff
patch for the SDL-1.2 version (2.17 KB, patch)
2019-07-11 17:39 UTC, Ozkan Sezer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ozkan Sezer 2019-07-11 17:38:55 UTC 
Created attachment 3877 [details]
patch for SDL2_image

libwebpdecoder is available if libwebp is configured with the
--enable-libwebpdecoder switch.  The attached patches allow
configuring SDL_image to use libwebpdecoder instead of the full
version of libwebp: full libwebp is still the default, so the
original behavior doesn't change.

OK to apply?
Comment 1 Ozkan Sezer 2019-07-11 17:39:28 UTC 
Created attachment 3878 [details]
patch for the SDL-1.2 version
Comment 2 Sam Lantinga 2019-07-12 17:24:18 UTC 
That sounds reasonable, but what about trying to load both?
Comment 3 Ozkan Sezer 2019-07-12 19:10:35 UTC 
(In reply to Sam Lantinga from comment #2)
> That sounds reasonable, but what about trying to load both?

None of the other code does such a thing, although no other loader
in SDL_image uses alternative libs:  The only one I am aware of is
SDL_mixer either using libvorbisfile or tremor, and that is an xor
not an or.

I _might_ try doing what you suggest though, if you want it?
Comment 4 Sam Lantinga 2019-07-14 23:34:13 UTC 
Yes please, that will give developers the flexibility of including whichever library makes sense with their application.
Comment 5 Ozkan Sezer 2019-08-19 18:37:42 UTC 
Applied this for now (been forgetting it), until I implement what Sam requested.
Comment 6 Ozkan Sezer 2020-12-21 21:17:20 UTC 
The functionality is there as of Aug. 2019.  I don't think I'll
improve this any further.  Closing.