We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4712 - hidapi not enabled when building with CMake
Summary: hidapi not enabled when building with CMake
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: joystick (show other bugs)
Version: 2.0.9
Hardware: x86_64 Linux
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.10
Depends on:
Blocks:
 
Reported: 2019-07-06 15:03 UTC by Marius Elvert
Modified: 2019-07-08 23:36 UTC (History)
0 users

See Also:

Attachments
CMake HIDAPI support... (6.33 KB, patch)
2019-07-08 23:01 UTC, Ryan C. Gordon 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Elvert 2019-07-06 15:03:52 UTC 
SDL_JOYSTICK_HIDAPI does not seem to be #defined in the CMake build path. 
It is completely missing in SDL_config.h.cmake, and does not seem to be set in the CMakeLists.txt either.
T
Comment 1 Sam Lantinga 2019-07-06 23:02:55 UTC 
Ryan, can you fix this for 2.0.10?

Thanks!
Comment 2 Ryan C. Gordon 2019-07-08 23:01:36 UTC 
Created attachment 3872 [details]
CMake HIDAPI support...


This patch adds HIDAPI support for CMake. I'll push this to revision control if we think it's not too late for 2.0.10.

--ryan.
Comment 3 Sam Lantinga 2019-07-08 23:25:06 UTC 
It's not too late. BTW, it looks like you're missing the joystick/hidapi/*.c files here too... ?
Comment 4 Ryan C. Gordon 2019-07-08 23:36:35 UTC 
This patch is now https://hg.libsdl.org/SDL/rev/800524378309

(the hidapi/*.c files are added in CheckHIDAPI in cmake/sdlchecks.cmake)

--ryan.