Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X (darwin) builds use incorrect(?) hard-coded paths #3318

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

OS X (darwin) builds use incorrect(?) hard-coded paths #3318

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 2.0.9
Reported for operating system, platform: macOS 10.13, x86

Comments on the original bug report:

On 2019-07-03 04:44:13 +0000, sh1 wrote:

Hard-coded paths appear in configure (line ~20350) and in src/video/x11/SDL_x11opengl.c (line ~39), both referring to /usr/X11R6/lib, but for whatever reason that path is not present on my system and the correct path seems to be /opt/X11/lib.

I don't know why the paths are the way they are, but either homebrew or XQuartz or Migration Assistant (horror!) put them where they are and I don't like to question it too much.

These paths should at least respect the --x-libraries= option given to configure, right?

When they're incorrect the library builds just fine, but the fixed paths end up in the compiled library and it won't respect search paths so the X11 driver fails to load.

On 2019-07-30 17:49:36 +0000, Ryan C. Gordon wrote:

(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.

On 2019-09-20 20:47:36 +0000, Ryan C. Gordon wrote:

We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.

On 2019-09-20 20:48:42 +0000, Ryan C. Gordon wrote:

We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.

On 2019-10-16 02:50:03 +0000, Ryan C. Gordon wrote:

As of https://hg.libsdl.org/SDL/rev/502bb7d04f0a, we check for X11 at /opt/X11 on the Mac. XQuartz is always installed there (and if there's ever an install at /usr/X11R6, it's a symlink to /opt/X11 anyhow, so there's no reason to check for a fallback).

--ryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant