We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4662 - SDL failed to build due to error LNK2019: unresolved external symbol _memset referenced in function _IMA_ADPCM_Decode with MSVC on Windows
Summary: SDL failed to build due to error LNK2019: unresolved external symbol _memset ...
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86 Windows 10
: P2 major
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-10 06:31 UTC by LinGao
Modified: 2019-06-11 06:16 UTC (History)
1 user (show)

See Also:

Attachments
log_x86_build (28.35 KB, text/plain)
2019-06-10 06:31 UTC, LinGao 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description LinGao 2019-06-10 06:31:36 UTC 
Created attachment 3814 [details]
log_x86_build

Hi,

We build SDL with Visual studio 2017 compiler on Windows Server 2016, but it failed to build due to error LNK2019: unresolved external symbol _memset referenced in function _IMA_ADPCM_Decode on latest default branch. And we found that it can be first reproduced on a39d8cdf50f4 changeset. Could you please help have a look about this issue? Thanks in advance!

Steps to Reproduce:
1.hg clone https://hg.libsdl.org/SDL D:\SDL\src
2.Open a VS 2017 x86 command prompt as admin and browse to D:\SDL
3.msbuild /p:Configuration=Release /p:Platform=Win32 /p:WindowsTargetPlatformVersion=10.0.17134.0 VisualC\SDL.sln /t:Rebuild

Actual result:
SDL_wave.obj : error LNK2019: unresolved external symbol _memset referenced in function _IMA_ADPCM_Decode [D:\SDL\src\VisualC\SDL\SDL.vcxproj]
D:\SDL\src\VisualC\Win32\Release\SDL2.dll : fatal error LNK1120: 1 unresolved externals [D:\SDL\src\VisualC\SDL\SDL.vcxproj]
Done Building Project "D:\SDL\src\VisualC\SDL\SDL.vcxproj" (Rebuild target(s)) -- FAILED.
SDL_wave.obj : error LNK2019: unresolved external symbol _memset referenced in function _IMA_ADPCM_Decode [D:\SDL\src\VisualC\SDL\SDL.vcxproj]
  D:\SDL\src\VisualC\Win32\Release\SDL2.dll : fatal error LNK1120: 1 unresolved externals [D:\SDL\src\VisualC\SDL\SDL.vcxproj]
Comment 1 Sam Lantinga 2019-06-10 15:49:43 UTC 
Fixed, thanks!
https://hg.libsdl.org/SDL/rev/cee49246e1bc
Comment 2 LinGao 2019-06-11 03:00:09 UTC 
Hi Sam,

Thanks for your reply!

We re-build with cee49246e1bc changeset. This issue still exists. Could you please help have a look about this issue? Thanks in advance!

Actual result:
SDL_wave.obj : error LNK2019: unresolved external symbol _memset referenced in function _IMA_ADPCM_Decode [D:\SDL\src\VisualC\SDL\SDL.vcxproj]
D:\SDL\src\VisualC\Win32\Release\SDL2.dll : fatal error LNK1120: 1 unresolved externals [D:\SDL\src\VisualC\SDL\SDL.vcxproj]
Done Building Project "D:\SDL\src\VisualC\SDL\SDL.vcxproj" (Rebuild target(s)) -- FAILED.
Comment 3 Ryan C. Gordon 2019-06-11 06:16:34 UTC 
(In reply to LinGao from comment #2)
> We re-build with cee49246e1bc changeset. This issue still exists. Could you
> please help have a look about this issue? Thanks in advance!

We missed one; it's fixed now in https://hg.libsdl.org/SDL/rev/4fb5e61382b7

--ryan.