We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4632 - Buffer overflow when calling SDL_SetWIndowIcon()
Summary: Buffer overflow when calling SDL_SetWIndowIcon()
Status: RESOLVED WORKSFORME
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: 2.0.9
Hardware: x86_64 OpenBSD
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.12
Depends on:
Blocks:
 
Reported: 2019-05-18 09:43 UTC by Leonid Bobrov
Modified: 2019-10-26 17:00 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid Bobrov 2019-05-18 09:43:13 UTC 
Source file (I commented SDL_SetWindowIcon() call): https://github.com/OrangeGrayCyan/warsow/blob/master/source/sdl/sdl_glw.c
Backtrace (if that call is uncommented): https://github.com/mazocomp/openbsd-wip/blob/e1eb51c721315c8e9b3bdbb63a2698b32a252e6e/games/warsow/BACKTRACE
Comment 1 Ryan C. Gordon 2019-07-30 17:49:37 UTC 
(Sorry if you get several emails like this, we're marking a bunch of bugs.)

We're hoping to ship SDL 2.0.11 on a much shorter timeframe than we have historically done releases, so I'm starting to tag bugs we hope to have closed in this release cycle.

Note that this tag means we just intend to scrutinize this bug for the 2.0.11 release: we may fix it, reject it, or even push it back to a later release for now, but this helps give us both a goal and a wishlist for the next release.

If this bug has been quiet for a few months and you have new information (such as, "this is definitely still broken" or "this got fixed at some point"), please feel free to retest and/or add more notes to the bug.

--ryan.
Comment 2 Sylvain 2019-09-03 10:59:05 UTC 
Can access the source code ... can you attach a testcase maybe, the stack trance and the icon file ?

I just tried on linux/x11 and this is still working. I have no open-bsd, as it's described in the report ..
Comment 3 Ryan C. Gordon 2019-09-20 20:47:37 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 4 Ryan C. Gordon 2019-09-20 20:48:40 UTC 
We're changing how we do SDL release versions; now releases will be even numbers (2.0.10, 2.0.12, etc), and as soon as we tag a release, we'll move the internal version number to an odd number (2.0.12 ships, we tag the latest in revision control as 2.0.13 immediately, which will become 2.0.14 on release, etc).

As such, I'm moving the bugs tagged with target-2.0.11 to target 2.0.12. Sorry if you get a lot of email from this change!

Thanks,
--ryan.
Comment 5 Ryan C. Gordon 2019-10-26 17:00:44 UTC 
Yeah, both of these GitHub users are totally gone.

I'm marking this as WORKSFORME until we have more information. Please reopen if this is still happening for you!

--ryan.