We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4609 - [PATCH] riscos: Clean up SWI calls
Summary: [PATCH] riscos: Clean up SWI calls
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: *don't know* (show other bugs)
Version: HG 1.2
Hardware: ARM RISC OS
: P2 normal
Assignee: Ryan C. Gordon
QA Contact: Sam Lantinga
URL:
Keywords:
Depends on:
Blocks: 4654
  Show dependency tree / graph
 
Reported: 2019-04-26 21:12 UTC by Cameron Cawley
Modified: 2019-06-08 20:17 UTC (History)
0 users

See Also:

Attachments
riscos: Clean up SWI calls (5.06 KB, patch)
2019-04-26 21:12 UTC, Cameron Cawley 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Cawley 2019-04-26 21:12:16 UTC 
Created attachment 3765 [details]
riscos: Clean up SWI calls

The main thing this patch does is it changes all OS_Byte and OS_Word calls to use _kernel_osbyte and _kernel_osword from the system headers. This should provide a minor optimization since it avoids having to call the SWIs via OS_CallASWIR12. Both functions are already used elsewhere in SDL, so this change shouldn't be a big deal.

It also uses the proper names for OS_ReadPalette and Joystick_Read.
Comment 1 Sam Lantinga 2019-06-08 20:17:25 UTC 
Patch added!
https://hg.libsdl.org/SDL/rev/c47cdc60c1b3