This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Makes sdl2-config.cmake find the library instead of using paths produced by autotools (sdl2-config.cmake.in-add-finding-capabilities.patch, text/plain, 2019-04-13 18:50:21 +0000, 8624 bytes)
• The sdl2-config.cmake replacement (sdl2-config.cmake, text/x-cmake, 2019-04-13 18:53:04 +0000, 7899 bytes)

Reported in version: 2.0.9
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2019-04-13 18:50:21 +0000, Leonardo wrote:

Created attachment 3749
Makes sdl2-config.cmake find the library instead of using paths produced by autotools

This is a followup to bug 2464 which added a bare sdl2-config.cmake to be used when the package is built with autotools (which is the case in most Linux distributions).

The generated sdl2-config.cmake is quite outdated in regards to what is the "modern" standard to using CMake, which is to use target_link_libraries to resolve both include and linking dependencies. It also misses linking to "mwindows" on MinGW and the .dmg version for Macintosh targets.

I took the FindSDL2.cmake flying around the internets as a starting point (specifically 1) since it always worked well enough in th past and then made it declare proper IMPORTED cmake targets.

The result is the proposed patch, which I believe fixes bug 4116 and bug 4225.

On 2019-04-13 18:53:04 +0000, Leonardo wrote:

Created attachment 3750
The sdl2-config.cmake replacement

On 2020-02-07 15:20:18 +0000, wrote:

This is not a good solution. What you wrote is a Find-Module not a config. A config should be configured to contain the correct paths as per the installation so using paths produced by autotools is fine. You can and should use variables set by configure to set the correct values in the config file.

But you are right: The config should also create an imported target SDL2::SDL2 which has everything set. The values should come from configure (see above)