We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 4593 - Respect CMake's BUILD_SHARED_LIBS default behavior
Summary: Respect CMake's BUILD_SHARED_LIBS default behavior
Status: RESOLVED FIXED
Alias: None
Product: SDL
Classification: Unclassified
Component: build (show other bugs)
Version: HG 2.1
Hardware: x86 Other
: P2 normal
Assignee: Sam Lantinga
QA Contact: Sam Lantinga
URL:
Keywords: target-2.0.10
Depends on:
Blocks:
 
Reported: 2019-04-12 11:05 UTC by tschwinger
Modified: 2019-06-08 21:36 UTC (History)
0 users

See Also:

Attachments
Respect BUILD_SHARED_LIBS when defined (1.75 KB, patch)
2019-04-12 11:05 UTC, tschwinger 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tschwinger 2019-04-12 11:05:37 UTC 
Created attachment 3744 [details]
Respect BUILD_SHARED_LIBS when defined

Respect the BUILD_SHARED_LIBS variable when defined, and build either shared or static libs, which is CMake's default behavior (See https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html).

If the variable is not defined, the current behavior remains unchanged and both variants are built where the platform supports it. This way, it remains possible to build both in one shot, which seems convenient for distro builds and useful to promote some consistency between them.
Comment 1 tschwinger 2019-04-12 12:30:03 UTC 
This patch (#4593) and #4594 can be checked out from https://github.com/tschw/SDL
Comment 2 Ryan C. Gordon 2019-05-18 18:48:54 UTC 
Tagging a bunch of bugs with "target-2.0.10" so we have a clear list of things to address before a 2.0.10 release.

Please note that "addressing" one of these bugs might mean deciding to defer on it until after 2.0.10, or resolving it as WONTFIX, etc. This is just here to tell us we should look at it carefully, and soon.

If you have new information or feedback on this issue, this is a good time to add it to the conversation, as we're likely to be paying attention to this specific report in the next few days/weeks.

Thanks!

--ryan.
Comment 3 Sam Lantinga 2019-06-08 21:36:18 UTC 
Patch added, thanks!
https://hg.libsdl.org/SDL/rev/4063a5ebe39b